Add NodeExecutionURL #822
Closed
Add NodeExecutionURL #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
commented
Oct 18, 2023
| return ( | ||
| <WaitForData {...executionData}> | ||
| <PanelSection> | ||
| <LiteralMapViewer | ||
| map={executionData.value.fullInputs} | ||
| mapTaskIndex={taskIndex} | ||
| /> | ||
| {executionData.value.fullInputs?.literals && ( |
There was a problem hiding this comment.
How do I render ExecutionNodeURL only if executionData.value.fullInputs?.literals not None?
{executionData.value.fullInputs?.literals && doesn't work
There was a problem hiding this comment.
@ursucarina , can you help?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #822 +/- ##
==========================================
- Coverage 63.34% 63.27% -0.07%
==========================================
Files 527 528 +1
Lines 13400 13427 +27
Branches 2554 2560 +6
==========================================
+ Hits 8488 8496 +8
- Misses 4912 4931 +19
☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
eapolinario
reviewed
Oct 18, 2023
| rr = FlyteRemote( | ||
| Config.auto(), | ||
| remote = FlyteRemote( | ||
| Config.for_endpoint(endpoint="localhost:30080"), |
There was a problem hiding this comment.
Can we get that address from the app itself? This should be the endpoint it uses to talk to admin, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Click Flyte button: copy flyte URL
Shift + Flyte button: copy the code snippet
Click the code snippet: copy the code snippet
Type
Are all requirements met?
Complete description
Tracking Issue
NA
Follow-up issue
NA